Suppress the progress bar with --quiet and --log#13467
Merged
Conversation
ichard26
force-pushed
the
bug/progress-bar-suppression
branch
from
5e2bfd3 to
e25b446
Compare
If users still want the progress bar, then --progress-bar on will do the trick. To make this work, a new "auto" mode has been added. It's equivalent to "on" when running at default or higher verbosity, "off" otherwise. Co-authored-by: q0w <[email protected]>
ichard26
force-pushed
the
bug/progress-bar-suppression
branch
from
e25b446 to
99ca8b3
Compare
| if options.debug_mode: | ||
| self.verbosity = 2 | ||
|
|
||
| if hasattr(options, "progress_bar") and options.progress_bar == "auto": |
Member
There was a problem hiding this comment.
Does a hasattr check really need to be done here or is this to guard against some type hinter / IDE warning? I don't have a good grasp on the options object, so this is a genuine question.
Member
Author
There was a problem hiding this comment.
Not every command accepts --progress-bar so the attribute is not guaranteed to exist unfortunately.
notatallshaw
approved these changes
Jul 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If users still want the progress bar, then --progress-bar on will do the trick. To make this work, a new "auto" mode has been added. It's equivalent to "on" when running at default or higher verbosity, "off" otherwise.
Closes #11024.
Closes #10930.
Fixes #10915.