Closed
Conversation
notatallshaw
force-pushed
the
add-Version.replace
branch
from
0ee863d to
90306ae
Compare
Contributor
|
Would it make sense to call this |
Member
Author
|
I'll close this in favor of Henry's PR #1003 which completes the same goals as this PR but with a slightly different approach. |
This was referenced Nov 29, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #659
Supplants: #698
My goal with this replace API is to allow an easy way to efficiently strip parts of a
Versionto create a newVersionobject, as this is used at multiple points inSpecifierwhich currently do it via stringifying and recreating aVersionobject.As such I have kept the API strict and minimal, largely using integers instead of strings so it doesn't have to deal with unnormalized or invalid strings. It could be expanded in the future to allow strings or convenience parameters, like individual parts of the release (major, minor, patch) or individual parts of the pre-release (rc, beta, alpha).