Conversation
ofek
force-pushed
the
spdx
branch
4 times, most recently
from
4ab216d to
3d8d9af
Compare
|
I've got one suggestion: The PEP specifies that the supported SPDX license list is The code looks straightforward to me and it works fine. I wonder whether this should be a job running on every PR or only a part of the build path? Side note: the other task, pep440, doesn't seem to work anymore. I'll open an issue. |
1 task
3 tasks
ofek
commented
Sep 3, 2024
This was referenced Sep 4, 2024
ewdurbin
added a commit
to ewdurbin/packaging
that referenced
this pull request
Sep 4, 2024
Per feedback, integrate a variant of pypa#799 that builds a minimal JSON dataset to feed vendored license-expression 32K src/packaging/_spdx.json vs 848K src/packaging/_vendor/license_expression/data/scancode-licensedb-index.json
ewdurbin
added a commit
to ewdurbin/packaging
that referenced
this pull request
Sep 4, 2024
Per feedback, integrate a variant of pypa#799 that builds a minimal JSON dataset to feed vendored license-expression 32K src/packaging/_spdx.json vs 848K src/packaging/_vendor/license_expression/data/scancode-licensedb-index.json
ewdurbin
added a commit
to ewdurbin/packaging
that referenced
this pull request
Sep 5, 2024
Per feedback, integrate a variant of pypa#799 that builds a minimal JSON dataset to feed vendored license-expression 32K src/packaging/_spdx.json vs 848K src/packaging/_vendor/license_expression/data/scancode-licensedb-index.json
Contributor
Author
|
Superseded by #828 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In response to this comment by a maintainer expressing approval for license parsing functionality, this PR introduces an invoke task to update an enumeration encoded as a Python structure.
This setup is the same as what Hatchling does:
The parser itself and what the API should look like will be discussed in a separate PR.
The file may be generated by running:
invoke licenses.update