Fix prerelease detection for > and <#794
Conversation
|
Feedback would be appreciated. |
Is this for another PR? I don’t see the change here. |
It's in this PR, it's in the change to |
|
I tried to merge branch with 'main' to make sure this PR was still good, but forgot I don't have automatic CI rights, if someone could approve CI run I'd be appreciative. |
|
Anything blocking this? Do I need to do anything for a changelog entry here? |
d70d341 to
a0e7b90
Compare
brettcannon
left a comment
There was a problem hiding this comment.
#788 (comment) has some examples. We probably should have some tests for those.
0a4eec2 to
42c1f6d
Compare
Added specifier tests to match. |
0f814e5 to
cf7ad44
Compare
cf7ad44 to
843c31c
Compare
|
The specifics of this came up today in astral-sh/uv#6640 It reminded me to check this PR, it seems there was a transient CI error, I added some more tests (and after correcting them) the transient CI error vanished. |
|
I'm going to give @pradyunsg a chance to (dis)agree to the semantic change before I merge. |
|
Thanks, @notatallshaw ! |
Fixes #788
And adds an explicit test for
!=based on #776 (comment)