tags: make _platform_tags public#446
Merged
brettcannon merged 2 commits intopypa:mainfrom Aug 27, 2021
Merged
Conversation
FFY00
force-pushed
the
make-platform-tags-public
branch
from
aaca0ec to
e47fe47
Compare
Member
|
I don't have a specific opposition to this idea, although I'm not sure what others think. There's also no documentation to go with this, so if we choose to move forward with this then that will need to be rectified. |
Member
|
I'm fine with this as a concept -- although, as you said, documentation updates are likely necessary for this. |
brettcannon
requested changes
Jul 16, 2021
Member
brettcannon
left a comment
brettcannon
left a comment
There was a problem hiding this comment.
Without reviewing the code (and assuming no objections come up to exposing this part of the API), doc changes are needed.
Member
Author
|
No worries, I will do that next week. |
FFY00
force-pushed
the
make-platform-tags-public
branch
from
e47fe47 to
a0cfe99
Compare
There are situations where we may need to look at the compatible platform versions. The best workaround for this would be using compatible_tags and striping down the unnecessary fields. There is already a precedent for this, mac_platforms. Signed-off-by: Filipe Laíns <[email protected]>
FFY00
force-pushed
the
make-platform-tags-public
branch
from
a0cfe99 to
d072dac
Compare
Member
Author
|
Friendly ping. |
Member
|
Sorry, been sick (and still recovering). Refreshed my review request to get it back into my queue. |
Member
Author
|
No worries 😄 |
brettcannon
approved these changes
Aug 27, 2021
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are situations where we may need to look at the compatible
platform versions. The best workaround for this would be using
compatible_tags and striping down the unnecessary fields. There is
already a precedent for this, mac_platforms.