Conversation
readme_renderer is already pulled in as twine's dependency.
pradyunsg
force-pushed
the
automated-releases
branch
from
e6e7048 to
80df76a
Compare
nox is a Python 3.5+ tool.
| # Not all segments are integers. | ||
| raise ValueError("non-integer segments") | ||
|
|
||
| # All is good. |
There was a problem hiding this comment.
Worth checking that the major version is 9 < major < 100 to basically make sure it's double digits?
There was a problem hiding this comment.
I mean, because we know that packaging is CalVer, I guess we could add a constraint of major == current_year % 100 here.
This can be done in a follow up though, and I'd prefer that. :)
|
|
||
|
|
||
| def _bump(session, *, version, file, kind): | ||
| session.log(f"Bump version to {version!r}") |
There was a problem hiding this comment.
I think this is comparing to _check_working_directory_state and _check_git_state.
That's because this call is actually making changes to the sources / git repository. I'd guessed that it'd be a good idea to have clear indicators of what changes are being made as we go (in the output itself).
Co-Authored-By: Brett Cannon <[email protected]>
Co-Authored-By: Brett Cannon <[email protected]>
pradyunsg
force-pushed
the
automated-releases
branch
from
84934d4 to
9086ad6
Compare
|
Alrighty, I've added in all the suggested changes here. Given that there's a green tick and none of the remaining comments look like blockers to me, I'm gonna go ahead and merge this PR. :) |
2 participants
Toward #253
Adds a
nox -s release -- YY.Nstep, to make it easier to do a release. In this PR, nearly all of the release process is automated -- the only remaining bit is the CHANGELOG, which we should probably tackle in a follow up.With this automation, chances are you'd still be prompted for a password for either git commits (if you sign commits by default) and/or prior to making the actual PyPI publish (if you're not storing PyPI passwords in
.pypirc).The automation also introduces a bunch of "sanity" checks, to protect against known bad-things in the environment, like misconfigured git remotes and dirty build directories (like, the things that have caused #260 or pypa/pip#7620). :)