Merge typeshed's setuptools._distutils annotations#329
Conversation
Add a few missing
Another missing
| @deprecated("format_commands is now a dict. append is deprecated.") | ||
| def append(self, item: object) -> None: | ||
| warnings.warn( | ||
| """format_commands is now a dict. append is deprecated.""", | ||
| "format_commands is now a dict. append is deprecated.", |
There was a problem hiding this comment.
Thanks for introducing me to this technique. I don't love it, because it's duplicative and adds a lot of boilerplate in the import section, but if this is the best practice, let's keep it.
|
Aouch, that's an ugly commit history, that one could've used a squash ^^" Oh well... |
😬 I tend not to squash merge except when flagged specifically (because a squash is an irreversible rewrite of history that can mask real issues). I don't mind the history, though I do sometimes squash and/or rewrite the history for a nicer story. Honestly, I'd not worry too much about it. The merge commit itself reflects the PR and anyone uninterested in the details can just follow the first parent. |
2 participants
Merges the annotations from: https://github.com/python/typeshed/tree/main/stubs/setuptools/setuptools/_distutils
This should allow typeshed to not have to expose and duplicate the private module to add types, instead referencing it directly in https://github.com/python/typeshed/tree/main/stubs/setuptools/distutils
It'll also improve base types for setuptools in pypa/setuptools#4689 / pypa/setuptools#4704
PathLikeunions are repeated often, I could do like I did in setuptools and create runtime aliases: https://github.com/pypa/setuptools/blob/main/setuptools/_path.py