Merged
Conversation
DimitriPapadopoulos
force-pushed
the
PERF
branch
from
2644a55 to
4a0149c
Compare
jaraco
reviewed
Jul 1, 2024
Member
jaraco
left a comment
jaraco
left a comment
There was a problem hiding this comment.
Looks good. I have a few comments/suggestions, and a TODO for me to investigate what's going on with the diff.
DimitriPapadopoulos
force-pushed
the
PERF
branch
from
39353cf to
b7e2882
Compare
PERF102 When using only the values of a dict use the `values()` method
PERF402 Use `list` or `list.copy` to create a copy of a list
DimitriPapadopoulos
force-pushed
the
PERF
branch
2 times, most recently
from
edfa8e0 to
df62fc3
Compare
PERF403 Use a dictionary comprehension instead of a for-loop
DimitriPapadopoulos
force-pushed
the
PERF
branch
from
df62fc3 to
2b5815c
Compare
Contributor
Author
|
About the previous CI failure: my "fix" for |
jaraco
approved these changes
Aug 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have not applied this one:
I believe the rest of the changes result in more readable code, but I am not certain about this one. In the absence of measured performance gains, I have left it out. I am happy to apply the
PERF203rule as well if you want me too.