Ensure a missing target is still indicated as 'sources are newer' even when there are no sources.

jaraco · jaraco · commit 30b7331b07fb · 2024-08-19T16:11:46.000-04:00
Closes #284
diff --git a/distutils/_modified.py b/distutils/_modified.py
@@ -63,7 +63,7 @@ def missing_as_newer(source):
         return missing == 'newer' and not os.path.exists(source)
 
     ignored = os.path.exists if missing == 'ignore' else None
-    return any(
+    return not os.path.exists(target) or any(
         missing_as_newer(source) or _newer(source, target)
         for source in filter(ignored, sources)
     )
diff --git a/distutils/tests/test_modified.py b/distutils/tests/test_modified.py
@@ -119,7 +119,6 @@ def test_newer_pairwise_group(groups_target):
     assert newer == ([groups_target.newer], [groups_target.target])
 
 
-@pytest.mark.xfail(reason="pypa/distutils#284")
 def test_newer_group_no_sources_no_target(tmp_path):
     """
     Consider no sources and no target "newer".

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ def missing_as_newer(source):`
`63`	`63`	`return missing == 'newer' and not os.path.exists(source)`
`64`	`64`
`65`	`65`	`ignored = os.path.exists if missing == 'ignore' else None`
`66`		`- return any(`
	`66`	`+ return not os.path.exists(target) or any(`
`67`	`67`	`missing_as_newer(source) or _newer(source, target)`
`68`	`68`	`for source in filter(ignored, sources)`
`69`	`69`	`)`