Make container-engine a build (non-global) option#1792
Merged
Conversation
Lets users specify different container-engine settings for different builds. Especially useful with the create_args setting, such as 1771.
henryiii
reviewed
Mar 21, 2024
Contributor
henryiii
left a comment
henryiii
left a comment
There was a problem hiding this comment.
This also needs to be updated in the schema. I can do that if it's helpful.
Contributor
Author
|
I've had a go at that @henryiii . Pretty simple to do, thanks to the tooling. I don't know how to update the schemastore, if that's necessary? Actually, maybe that should be part of the release process? |
henryiii
approved these changes
May 7, 2024
Contributor
|
You have to make a PR to SchemaStore. Not sure how easy that would be to automate. But it's a good idea to do it around release time if the schema changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lets users specify different container-engine settings for different builds using TOML overrides. Especially useful with the create_args setting, such as #1771.