Repository navigation
feat: SDist builds - #1096
Merged
Merged
feat: SDist builds#1096
Conversation
henryiii
force-pushed
the
henryiii/feat/sdist
branch
from
April 27, 2022 03:11
4db6b02 to
095a917
Compare
when calling like 'python -m cibuildwheel', we get errors like
usage: __main__.py [-h] [--platform {auto,linux,macos,windows}] [--archs ARCHS] [--output-dir OUTPUT_DIR] [--config-file CONFIG_FILE]
[--print-build-identifiers] [--allow-empty] [--prerelease-pythons]
[package_dir]
__main__.py: error: unrecognized arguments: --sad
With this change, we get error outputs like:
usage: cibuildwheel [-h] [--platform {auto,linux,macos,windows}] [--archs ARCHS] [--output-dir OUTPUT_DIR] [--config-file CONFIG_FILE]
[--print-build-identifiers] [--allow-empty] [--prerelease-pythons]
[package_dir]
cibuildwheel: error: unrecognized arguments: --asda
henryiii
force-pushed
the
henryiii/feat/sdist
branch
2 times, most recently
from
April 27, 2022 05:58
9f07f8a to
f6e4420
Compare
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/sdist
branch
2 times, most recently
from
April 27, 2022 17:29
dd9c23f to
68dd0d0
Compare
henryiii
force-pushed
the
henryiii/feat/sdist
branch
from
April 27, 2022 18:55
68dd0d0 to
b1e8549
Compare
joerick
reviewed
Apr 27, 2022
joerick
left a comment
joerick
left a comment
Contributor
There was a problem hiding this comment.
You're right! This approach is much cleaner than the extra entrypoint. Let's hope it passes the tests. I've a few minor comments, too.
henryiii
force-pushed
the
henryiii/feat/sdist
branch
from
April 27, 2022 21:12
63d841b to
2ef1a6a
Compare
henryiii
force-pushed
the
henryiii/feat/sdist
branch
from
April 27, 2022 21:18
2ef1a6a to
3505466
Compare
henryiii
marked this pull request as ready for review
April 28, 2022 00:42
Closed
henryiii
commented
Apr 28, 2022
| # This are always relative to the base directory, even in SDist builds | ||
| args.output_dir = args.output_dir.resolve() | ||
|
|
||
| # Standard builds if a directory or non-existent path is given |
Contributor
Author
There was a problem hiding this comment.
Avoiding making a new directory if this ends with .tar.gz
joerick
approved these changes
Apr 29, 2022
Contributor
|
Thanks @henryiii , at a first test this seems to work great! |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a followup to both close #1072 and close #1020 to attempt to build from SDists. This avoids a new entry point, works better with pipx and GitHub Actions, and should be the same as #1072 conceptually but with a single entry point.
I am not adding
{project}to--config-file, since it was not supported before (and{package}continues to work properly). It could be added later if desired (for both modes).