Merge pull request #1311 from henryiii/henryiii/fix/rootpip2

joerick · web-flow · commit 36a61012f3e2 · 2022-10-26T19:45:43.000+01:00
fix: hide root pip warning and upgrade check
diff --git a/cibuildwheel/linux.py b/cibuildwheel/linux.py
@@ -189,6 +189,8 @@ def build_in_container(
         log.step("Setting up build environment...")
 
         env = container.get_environment()
+        env["PIP_DISABLE_PIP_VERSION_CHECK"] = "1"
+        env["PIP_ROOT_USER_ACTION"] = "ignore"
 
         # put this config's python top of the list
         python_bin = config.path / "bin"
diff --git a/test/test_0_basic.py b/test/test_0_basic.py
@@ -20,7 +20,7 @@
 )
 
 
-def test(tmp_path, build_frontend_env):
+def test(tmp_path, build_frontend_env, capfd):
     project_dir = tmp_path / "project"
     basic_project.generate(project_dir)
 
@@ -31,6 +31,12 @@ def test(tmp_path, build_frontend_env):
     expected_wheels = utils.expected_wheels("spam", "0.1.0")
     assert set(actual_wheels) == set(expected_wheels)
 
+    # Verify pip warning not shown
+    captured = capfd.readouterr()
+    for stream in (captured.err, captured.out):
+        assert "WARNING: Running pip as the 'root' user can result" not in stream
+        assert "A new release of pip available" not in stream
+
 
 @pytest.mark.skip(reason="to keep test output clean")
 def test_sample_build(tmp_path, capfd):
