Update codespell version in pre-commit#4938
Conversation
| @@ -0,0 +1,2 @@ | |||
| atmost | |||
| COO | |||
There was a problem hiding this comment.
We also have "--ignore-words-list", "ags,aray,asend,ba,classs,crate,falsy,feld,inflight,lits,nd,slowy,te,oint,conveniant" in the .pre-commit-config file, presumably we don't want to have both an inline ignore list and a separate file.
There was a problem hiding this comment.
Ah I missed it somehow, so many different ways to configure these things ...
I pushed a commit moving the config to pyproject.toml. I guess one small advantage is that you can run codespell directly if you want and it will use the config rather than having to run precommit run codespell --files <file>. I can definitely revert it if you prefer to have everything in precommit config.
There was a problem hiding this comment.
so many different ways to configure these things
Seriously.
moving the config to pyproject.toml
Sounds good to me, I don't have a strong preference as long as we keep it consistent.
| [tool.codespell] | ||
| ignore-words = 'tools/codespell_ignore_words.txt' | ||
| skip = 'benchmark/benchmarks/pystone_benchmarks/pystone.py,src/js/package-lock.json' | ||
| skip = 'benchmark/benchmarks/pystone_benchmarks/pystone.py,src/js/package-lock.json,tools/codespell_ignore_words.txt' |
| @@ -0,0 +1,2 @@ | |||
| atmost | |||
| COO | |||
There was a problem hiding this comment.
so many different ways to configure these things
Seriously.
moving the config to pyproject.toml
Sounds good to me, I don't have a strong preference as long as we keep it consistent.
2 participants
Description
This updates codespell in precommit. This would help for #4935 because
precommit.ciis unhappy and I don't manage to make it ignore "COO" for an unkown reason ...I needed to add an ignore-list because somehow
atmostis flagged by pre-commit 2.3.0 as a typo ...codespell 2.3.0 detected real typos in other files that I fixed.
Checklists
I ticked all of them since this does not seem applicable