Fix recipes that do not link to their dependencies correctly#4878
Merged
hoodmane merged 1 commit intopyodide:mainfrom Jun 21, 2024
Merged
Fix recipes that do not link to their dependencies correctly#4878hoodmane merged 1 commit intopyodide:mainfrom
hoodmane merged 1 commit intopyodide:mainfrom
Conversation
ryanking13
commented
Jun 21, 2024
| package: | ||
| name: openssl | ||
| version: 1.1.1n | ||
| version: 1.1.1w |
Member
Author
There was a problem hiding this comment.
This is not version update, the version number was incorrect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Splitted off from #4876.
What this PR does is basically fixing incorrect shared library dependencies.
For instance,
cryptographypackage depends onopenssl, so the python extension should link tolibssl.so.However, before this PR, it was not linked correctly.
$ pyodide auditwheel show cryptography-42.0.5-cp312-cp312-pyodide_2024_0_wasm32.whl {'cryptography\\hazmat\\bindings\\_rust.cpython-312-wasm32-emscripten.so': []}After this PR, it is linked correctly.
$ pyodide auditwheel show cryptography-42.0.5-cp312-cp312-pyodide_2024_0_wasm32.whl { │ 'cryptography\\hazmat\\bindings\\_rust.cpython-312-wasm32-emscripten.so': [ │ │ 'libssl.so', │ │ 'libcrypto.so' │ ] }Why do we need this change?
Because it is how shared libraries should work.
Why was this working before?
Because we loaded dependencies globally.
opensslis loaded globally, so its symbols were visible tocryptographyeven if they are not linked. However, #4876 will change all library loading mechanism to local, so all shared libraries should now have correct dependencies to work.