Update numpy to 1.26.4 and don't set MESON env variable#4502
Merged
hoodmane merged 1 commit intopyodide:mainfrom Feb 9, 2024
Merged
Update numpy to 1.26.4 and don't set MESON env variable#4502hoodmane merged 1 commit intopyodide:mainfrom
hoodmane merged 1 commit intopyodide:mainfrom
Conversation
Member
|
Thanks @ryanking13! |
This was referenced Feb 27, 2024
ryanking13
added a commit
to ryanking13/pyodide
that referenced
this pull request
Mar 30, 2024
From meson-python 0.15, $MESON env variable is used to overwrite the meson binary path. We don't want that behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #4498
From
meson-python0.15,$MESONenv variable is used to overwrite the meson binary path. We don't want that behavior.Checklists