Skip to content

Comments

src/py/pyproject.toml: Move metadata here from setup.cfg#4472

Merged
hoodmane merged 3 commits intopyodide:mainfrom
passagemath:pyproject_metadata
Feb 2, 2024
Merged

src/py/pyproject.toml: Move metadata here from setup.cfg#4472
hoodmane merged 3 commits intopyodide:mainfrom
passagemath:pyproject_metadata

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Feb 2, 2024

Description

Modernizing metadata

@mkoeppe mkoeppe marked this pull request as ready for review February 2, 2024 05:41
Copy link
Member

@hoodmane hoodmane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I guess when we release our next alpha we'll find out if this changed anything noticeable. Probably I should do a quick before and after comparison of the wheel contents...

Thanks again @mkoeppe for helping with these chores!

@hoodmane
Copy link
Member

hoodmane commented Feb 2, 2024

Okay, well the file set is exactly the same for both the sdist and wheels. I was expecting setup.cfg to go away in the sdist but setuptools apparently makes one with:

[egg_info]
tag_build = 
tag_date = 0

Other than that, the sdist changes are what we'd obviously expect. The difference between the wheels is:

 Metadata-Version: 2.1
 Name: pyodide-py
 Version: 0.26.0.dev0
-Summary: "A Python package providing core interpreter functionality for Pyodide."
-Home-page: https://github.com/pyodide/pyodide
+Summary: A Python package providing core interpreter functionality for Pyodide
 Author: Pyodide developers
+Project-URL: Homepage, https://github.com/pyodide/pyodide
 Project-URL: Bug Tracker, https://github.com/pyodide/pyodide/issues
 Project-URL: Documentation, https://pyodide.org/en/stable/
 Classifier: Programming Language :: Python :: 3
 Classifier: License :: OSI Approved :: Mozilla Public License 2.0 (MPL 2.0)
 Classifier: Operating System :: OS Independent
-Requires-Python: >=3.8
+Requires-Python: >=3.11
 Description-Content-Type: text/markdown

@hoodmane hoodmane merged commit eb6e03e into pyodide:main Feb 2, 2024
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 2, 2024

Thanks for checking this carefully!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants