Skip to content

Comments

New package ipython#4452

Merged
hoodmane merged 13 commits intopyodide:mainfrom
passagemath:ipython
Feb 26, 2024
Merged

New package ipython#4452
hoodmane merged 13 commits intopyodide:mainfrom
passagemath:ipython

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented Jan 30, 2024 •
edited
Loading

Description

The Sage library uses IPython.lib.pretty
Patches for making at least import IPython work on Pyodide have been upstreamed in 8.22, https://ipython.readthedocs.io/en/stable/whatsnew/version8.html

The other added packages are dependencies of IPython.

Checklists

This was referenced Jan 30, 2024
Merged
Closed
hoodmane
hoodmane reviewed Jan 30, 2024
View reviewed changes
Carreau added a commit to ipython/ipython that referenced this pull request Jan 31, 2024
@Carreau
IPython.utils._process_posix: import pexpect only when needed (#1…
4eab608 
…4312)

Delaying the import of `pexpect` to the first use.

This is needed to make `import IPython` work on Pyodide; see
pyodide/pyodide#4452
@hoodmane
Copy link
Member

hoodmane commented Jan 31, 2024

No action needed on this PR:

conftest.py:96: error: Module has no attribute "pyodide_runtimes"  [attr-defined]
conftest.py:143: error: Module has no attribute "pyodide_dist_dir"  [attr-defined]
conftest.py:259: error: Module has no attribute "pyodide_dist_dir"  [attr-defined]
packages/aiohttp/test_aiohttp.py:27: error: Module has no attribute "pyodide_dist_dir"  [attr-defined]

mypy can't make up its mind whether these are errors or not. It seems to keep going back and forward between failing with a request for # type:ignores on these lines and failing saying that the added type ignore is not needed. Any ideas on how to prevent problems like this @henryiii?

hoodmane
hoodmane approved these changes Jan 31, 2024
View reviewed changes
Copy link
Member

@hoodmane hoodmane left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM, please address my minor comments. It also needs a changelog entry. Thanks again @mkoeppe!

@mkoeppe mkoeppe force-pushed the ipython branch 2 times, most recently from 0732504 to 4823aa5 Compare February 1, 2024 22:03
mkoeppe added a commit to passagemath/downstream-pyodide that referenced this pull request Feb 1, 2024
@mkoeppe
docs/project/changelog.md: Mention packages added in pyodide#4452, mo…
9804644 
…ve changelog entry to packages subsection
@hoodmane
Copy link
Member

hoodmane commented Feb 2, 2024

Seems like it failed to apply the IPython patch.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 2, 2024

Yes, sorry, I need to backport it

@mkoeppe mkoeppe marked this pull request as draft February 2, 2024 04:38
@mkoeppe mkoeppe mentioned this pull request Feb 3, 2024
Merged
mkoeppe and others added 12 commits February 25, 2024 00:12
@mkoeppe
packages/{asttokens,executing,ipython,pure_eval,stack_data,traitlets,…
89f8287 
…wcwidth}: New
@mkoeppe
packages/ipython/test_ipython.py: New
d93b18b
@pre-commit-ci @mkoeppe
[pre-commit.ci] auto fixes from pre-commit.com hooks
c7c8deb 
for more information, see https://pre-commit.ci
@mkoeppe @hoodmane
packages/traitlets/meta.yaml: Abbreviate license
953f9fe 
Co-authored-by: Hood Chatham <[email protected]>
@pre-commit-ci @mkoeppe
[pre-commit.ci] auto fixes from pre-commit.com hooks
9e2439c 
for more information, see https://pre-commit.ci
@mkoeppe
packages/prompt_toolkit: New (ipython dep)
392efff
@mkoeppe
packages/ipython: Add ipython/ipython#14316 as a patch
6a7ca60
@mkoeppe
packages/ipython: Update to 8.21.0, drop patch
516ec2c
@mkoeppe
packages/ipython/test_ipython.py: Test IPython.lib.pretty a bit more
6d9930a
@pre-commit-ci @mkoeppe
[pre-commit.ci] auto fixes from pre-commit.com hooks
d851077 
for more information, see https://pre-commit.ci
@mkoeppe
docs/project/changelog.md: Mention packages added in pyodide#4452, mo…
830b8e0 
…ve changelog entry to packages subsection
@mkoeppe
package/ipython: Update to 8.22.1, remove patch, change to wheel package
fdf1e67
@mkoeppe mkoeppe marked this pull request as ready for review February 25, 2024 08:35
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 26, 2024

@hoodmane No more patches, and tests pass

@hoodmane
Copy link
Member

hoodmane commented Feb 26, 2024

Thanks!

@hoodmane hoodmane merged commit 6521888 into pyodide:main Feb 26, 2024
@mkoeppe mkoeppe mentioned this pull request Feb 26, 2024
Open
@hoodmane hoodmane mentioned this pull request Mar 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoodmane hoodmane hoodmane approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mkoeppe @hoodmane