pyodide_build.out_of_tree.venv: Monkey-patch platform.system for pip#4400
Merged
hoodmane merged 1 commit intopyodide:mainfrom Jan 22, 2024
Merged
pyodide_build.out_of_tree.venv: Monkey-patch platform.system for pip#4400hoodmane merged 1 commit intopyodide:mainfrom
pyodide_build.out_of_tree.venv: Monkey-patch platform.system for pip#4400hoodmane merged 1 commit intopyodide:mainfrom
Conversation
hoodmane
reviewed
Jan 22, 2024
Member
|
As a side effect, we'll be getting |
Contributor
Author
|
Yes, I think that's an improvement for Linux too. |
Member
|
It sure seems like it should be, but one never knows what sort of horrible crazy behavior we might be accidentally relying on. |
Member
|
Now I'm running into trouble because we don't monkeypatch |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On macOS, in out-of-tree venvs,
pipcannot install platform wheels.The computation of the supported wheel tags goes through https://github.com/pypa/packaging/blame/main/src/packaging/tags.py#L516; on macOS, it gives:
By monkey-patching
platform.systemto return something other than "Darwin", we get a suitable list of tags.Checklists