Fix scipy null pointer bug after migrating to meson#4313
Merged
ryanking13 merged 2 commits intopyodide:mainfrom Nov 28, 2023
Merged
Fix scipy null pointer bug after migrating to meson#4313ryanking13 merged 2 commits intopyodide:mainfrom
ryanking13 merged 2 commits intopyodide:mainfrom
Conversation
Contributor
|
Thanks for the fix! I am guessing the CI issue |
Member
Author
|
Yes, It started getting timeouts a few days ago, probably related to the 1.40 release of playwright. |
Member
Author
|
Thanks for the review! |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix #4310
Changing the symbol visibility fixes the error. I've been trying to understand what's going on for a few days, but it was unsuccessful. It probably has something to do with the emscripten GOT table storing duplicate symbols (
ndarray_from_pyobjfunction is exported from multiple shared libraries)... but I'm not sure.Anyway, this patch fixes the bug.
cc: @lesteve