Skip to content

MAINT Improve debug settings in Makefile.envs#2648

Merged
hoodmane merged 2 commits intopyodide:mainfrom
hoodmane:debug-settings
May 31, 2022
Merged

MAINT Improve debug settings in Makefile.envs#2648
hoodmane merged 2 commits intopyodide:mainfrom
hoodmane:debug-settings

Conversation

@hoodmane
Copy link
Copy Markdown
Member

@hoodmane hoodmane commented May 30, 2022

Add PYODIDE_SYMBOLS and PYODIDE_SOURCEMAP environment variables to adjust
debug symbol settings.

If either is set, run prettier on pyodide.asm.js.

Add PYODIDE_ASSERTIONS to set -DDEBUG_F.

hoodmane added 2 commits May 30, 2022 10:39
Add PYODIDE_SYMBOLS and PYODIDE_SOURCEMAP environment variables to adjust
debug symbol settings.

Add PYODIDE_ASSERTIONS to set -DDEBUG_F.
@hoodmane hoodmane mentioned this pull request May 30, 2022
1 task
Copy link
Copy Markdown
Member

@ryanking13 ryanking13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hoodmane!

@hoodmane
Copy link
Copy Markdown
Member Author

Thanks for the review!

@hoodmane hoodmane merged commit 951681c into pyodide:main May 31, 2022
@hoodmane hoodmane deleted the debug-settings branch May 31, 2022 00:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants