Fix word splitting on run_docker script#2260
Merged
hoodmane merged 2 commits intopyodide:mainfrom Mar 8, 2022
Merged
Conversation
ryanking13
changed the title
henryiii
reviewed
Mar 8, 2022
run_docker
Outdated
| CONTAINER=$(\ | ||
| docker run \ | ||
| "$PORT_CONFIGURATION_LINE" \ | ||
| $PORT_CONFIGURATION_LINE \ |
Contributor
There was a problem hiding this comment.
You can also make it explicit by using an array ("@{PORT_CONFIGURATION_LINE[@]}" + set it as an array), then you don't need to disable the shellcheck check.
Member
Author
There was a problem hiding this comment.
Yes, that could be better for consistency. Thanks for the suggestion.
henryiii
approved these changes
Mar 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#2257 added a double quote on every bash variable, but there was an error because we have some intended word-splitting stuff.