MAINT Clean up environment variables and pywasmcross#2053
Merged
hoodmane merged 15 commits intopyodide:mainfrom Dec 20, 2021
Merged
MAINT Clean up environment variables and pywasmcross#2053hoodmane merged 15 commits intopyodide:mainfrom
hoodmane merged 15 commits intopyodide:mainfrom
Conversation
rth
reviewed
Dec 20, 2021
Member
rth
left a comment
rth
left a comment
There was a problem hiding this comment.
Thanks for doing this work! LGTM, when CI passes.
It would indeed be so much better to be able to run that command without the makefile.
Member
|
It looks like |
Member
Author
|
And it works! Just have to fix test-python. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is more maintenance on
pyodide-build. The goal is to make it so that directly invokingpyodide-buildfrom the command line actually works. This would be a huge benefit to debugging package builds, where it's a pain to select out individual failing build commands and repeat them because of issues with environment variables.In particular, this fixes
python -m pyodide_build buildall ../packages/ ../build --only="core"so that it runs without errors.
I also made some readability improvements to pywasmcross.