Skip to content

fpcast2#2016

Closed
hoodmane wants to merge 35 commits intopyodide:mainfrom
hoodmane:fpcast2
Closed

fpcast2#2016
hoodmane wants to merge 35 commits intopyodide:mainfrom
hoodmane:fpcast2

Conversation

@hoodmane
Copy link
Copy Markdown
Member

@hoodmane hoodmane commented Dec 3, 2021

A second, much simpler approach to handling the bad fpcasts.
There are only a few problematic call sites, so just patch call trampolines into the interpreter at these locations.

joemarshall and others added 23 commits May 12, 2021 10:14
@joemarshall
fixed signature of await function
5263422
@joemarshall
fix dictionary type signatures in cpython
c7938f0
@joemarshall
removed fpcast from commited makefile envs
34714a8
@joemarshall
numpy patches for function pointer problems
a74dd44
@joemarshall
remove binaryen patches for fpcast
7cbcad1
@joemarshall
makefile environment vars for no fpcast
2060f43
@joemarshall
separated out debug options
65050dc
@joemarshall
numpy imports with these settings
2309749
@joemarshall
more memory for chrome
a83f392
@joemarshall
removed debug stuff
53c018b
@joemarshall
more int return values fixed
b149944
@joemarshall
fix to numpy return values
9d9ecaf
@joemarshall
Merge branch 'main' of https://github.com/pyodide/pyodide into fpcast
a948956
@joemarshall
fix to build script for rebuilding
05965bb
Merge branch 'main' into fpcast
eefdcfc
@rth
Merge branch 'main' into fpcast
e47c264
@rth
Merge branch 'main' into fpcast
0265634
Remove fpcast flag from cffi build
354d8be
Add call trampoline patch
74db9df
Merge branch 'main' into fpcast2
0b04030
Trigger CI
2a617b0
Add forgotten emscripten include
ea5151e
Fix name errors
292fbf8
@ryanking13
Copy link
Copy Markdown
Member

ryanking13 commented Dec 4, 2021

I'm very looking forward to seeing this PR merged. Thank you for your efforts! 👍

@hoodmane
Copy link
Copy Markdown
Member Author

hoodmane commented Dec 4, 2021

There is still the problem of it breaking Chrome CI to deal with...

@hoodmane
Copy link
Copy Markdown
Member Author

hoodmane commented Dec 4, 2021

Okay, I think this is in good shape now:

  1. All tests pass on node and firefox
  2. All chrome tests time out. I still have no clue why. I tested locally on Chrome 90.0.4430.24, the version we use in CI. It works fine.

@hoodmane hoodmane mentioned this pull request Dec 5, 2021
Merged
@hoodmane
Copy link
Copy Markdown
Member Author

hoodmane commented Dec 5, 2021

Closed in favor of #2019.

@hoodmane hoodmane closed this Dec 5, 2021
@hoodmane hoodmane deleted the fpcast2 branch May 12, 2022 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hoodmane @ryanking13 @joemarshall @rth