Skip to content

Expose Module.FS#1692

Merged
hoodmane merged 7 commits intopyodide:mainfrom
bollwyvl:hoist-fs
Jul 10, 2021
Merged

Expose Module.FS#1692
hoodmane merged 7 commits intopyodide:mainfrom
bollwyvl:hoist-fs

Conversation

@bollwyvl
Copy link
Copy Markdown
Contributor

@bollwyvl bollwyvl commented Jul 7, 2021

I didn't add any examples or tests, but the docs seemed to update properly.

Screenshot from 2021-07-06 21-35-46

@bollwyvl
Copy link
Copy Markdown
Contributor Author

bollwyvl commented Jul 7, 2021

Given I'm having to duplicate the --lib in two places, how do we feel about biting the bullet and just having a src/js/tsconfig.json? There are probably some other static analysis advantages to be gained with more compiler flags that would start to get pretty lengthy at the CLI (though nothing on some of the these emcc calls 😆 )

@hoodmane
Copy link
Copy Markdown
Member

hoodmane commented Jul 8, 2021

Fine with me, I just set up the flags in the way that was fastest for me at the time.

@bollwyvl
Copy link
Copy Markdown
Contributor Author

bollwyvl commented Jul 8, 2021

Welp, i wouldn't consider the tsconfig.json a blocker for at least review... otherwise are any of the fails indicators of things i broke? seem like mostly timesout or stuff that flakes on the #1596, too.

@hoodmane
Copy link
Copy Markdown
Member

hoodmane commented Jul 8, 2021

Yeah CI failures are just just normal CI flakiness.

@hoodmane
Copy link
Copy Markdown
Member

We need a changelog entry for this and it would be good if you could add a simple test. Plus there are conflicts with package.json now.

@bollwyvl
Copy link
Copy Markdown
Contributor Author

I've done the tsconfig.json change, and added a test... but it appears to fail the same way as the other tests on main.

@hoodmane
Copy link
Copy Markdown
Member

hoodmane commented Jul 10, 2021

CI looks fine. If you update the changelog I will merge it.

@bollwyvl
Copy link
Copy Markdown
Contributor Author

update the changelog

Gah, literally the first thing you wrote! Incoming.

@hoodmane hoodmane merged commit 60acd00 into pyodide:main Jul 10, 2021
@hoodmane
Copy link
Copy Markdown
Member

hoodmane commented Jul 10, 2021

Thanks! A lot of people need to use this so it's good to have it public.

@bollwyvl
Copy link
Copy Markdown
Contributor Author

bollwyvl commented Jul 10, 2021 via email

@bollwyvl bollwyvl deleted the hoist-fs branch July 11, 2021 13:29
@hoodmane hoodmane mentioned this pull request Jun 17, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants