Merged
Conversation
rth
commented
Jul 3, 2021
| * The main bootstrap code for loading pyodide. | ||
| */ | ||
| import { Module } from "./module"; | ||
| import { Module } from "./module.js"; |
Member
Author
There was a problem hiding this comment.
Otherwise I was getting errors like,
Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/home/rth/src/pyodide/src/js/module' imported from
/home/rth/src/pyodide/src/js/api.js
Did you mean to import ../module.js?
hoodmane
approved these changes
Jul 3, 2021
hoodmane
reviewed
Jul 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This sets up a JS test suite using Mocha.
The goal is to be able to test individual functions in
src/jswithout running the build system.The other goal is to start playing with Node.js in the future, and have tests for it. Though then we would need to build Pyodide core first.
As to the choice of the test package. It looks like the popular ones are Mocha and Jest. I'm not familiar with neither. I went with the first one as it seems more lightweight and also more of a community project. But we can change that if anyone has strong opinions about it.