Simplify js2python string conversion code a bit#1679
Merged
hoodmane merged 1 commit intopyodide:mainfrom Jul 1, 2021
Merged
Conversation
Member
Author
|
There are problems in Firefox in the CI. I do not yet understand why. |
Member
Author
|
Problem was just a sporadic failure. |
Member
Author
|
We might want to revert this, it seems to be inconsistently breaking up firefox-core tests on CI (cannot reproduce test failures locally though). |
Member
|
Yes, it does look like there are more timeouts after the last few commits. Thoughg it could be also due to CircleCI having larger loads and being slower as well. |
hamlet4401
pushed a commit
to tytgatlieven/pyodide
that referenced
this pull request
Jul 3, 2021
hoodmane
pushed a commit
to hoodmane/pyodide
that referenced
this pull request
Jul 3, 2021
This reverts commit 9ec832b.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.