Merged
Conversation
This is needed for the upstream backend, and I believe is a noop under the fastcomp backend
Member
|
Thanks LGTM. I'll add mdboom and @joemarshall as co-authors to the commit once merged. If you adapt some of the other patches, don't hesitate to add a |
joemarshall
added a commit
to joemarshall/pyodide
that referenced
this pull request
Jan 3, 2021
This is needed for the upstream backend, and I believe is a noop under the fastcomp backend Co-authored-by: Michael Droettboom <[email protected]> Co-authored-by: Joe Marshall <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is needed for the upstream backend, and I believe is a noop under the fastcomp backend (and some packages already build with
-fPIC, but it doesn't hurt to specify twice)This is part of the changes in #637, #531, and joemarshall's emsripten 2.0 branch