gdbserver: be stricter about matching qC #1660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlyu
changed the title
ithinuel
approved these changes
Jun 4, 2024
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
|
hello, would you mind rebasing your PR so that we can re-run CI please ? <3 |
Don't match only the prefix of qC. Otherwise, compare-sections in gdb will fail, due to qCRC returning a thread ID.
ithinuel
force-pushed
the
fix-gdbserver-qC
branch
from
42c563e to
c353d7f
Compare
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't match only the prefix of qC. Otherwise, compare-sections in gdb will fail, due to qCRC returning a thread ID.