Add py.typed to mark package as typed (PEP 561)#926
Merged
termim merged 4 commits intopymssql:masterfrom Apr 1, 2025
NMertsch:master
Merged
Add py.typed to mark package as typed (PEP 561)#926termim merged 4 commits intopymssql:masterfrom NMertsch:master
termim merged 4 commits intopymssql:masterfrom
NMertsch:master
Conversation
Contributor
Author
|
Thanks @termim for triggering the builds. |
Contributor
|
@NMertsch it seems the build is fixed, you can try to return the pyproject.toml change. |
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #925
PEP 561:
I wasn't able to compile the package locally, so I don't know if this actually works.
The expected result is: File
py.typedis part of the package distribution, in the same directory as__init__.py.I saw
setuptoolsinpyproject.toml, so I followed their docs on how to include non-Python files.EDIT: The
setuptoolsapproach didn't work. Second attempt:MANIFEST.in.