Emit scalar DEMetropolis "scaling" stat#8178
Merged
Merged
Conversation
Like done with other Metropolis step methods.
Member
|
@michaelosthege we have two branches going on now, v6 (default) and main (bugfixes). For this one let's target main still and then I'll cherry pick it to v6. It will also get rid of the extra commits it's picking |
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
michaelosthege
force-pushed
the
fix-metropolis-tests
branch
from
84dec6b to
5c7a87c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8178 +/- ##
==========================================
- Coverage 84.56% 79.01% -5.55%
==========================================
Files 124 124
Lines 19866 19873 +7
==========================================
- Hits 16799 15703 -1096
- Misses 3067 4170 +1103
🚀 New features to boost your workflow:
|
michaelosthege
force-pushed
the
fix-metropolis-tests
branch
from
5c7a87c to
b0a0631
Compare
michaelosthege
changed the title
DEMetropolis "scaling" stat and track warmup count on IBaseTraceDEMetropolis "scaling" stat
ricardoV94
approved these changes
Mar 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #8172 by doing the same fix already done in #7871, closing #8169.
Follow-up to #8015 that tracks warmup information independent of stats onIBaseTrace/NDarraybackends:IBaseTrace.warmup_count()for counting the total number of warmup steps_sample_returnswitches to usingwarmup_count()instead of relying ontuneparameter. This works also when chains do not have the same number of warmup iterations.not worth it I guess
Type of change