Fix DEMetropolis stats type mismatch in population sampler output#8172
Open
SanketMeghale wants to merge 3 commits into
Open
Fix DEMetropolis stats type mismatch in population sampler output#8172SanketMeghale wants to merge 3 commits into
SanketMeghale wants to merge 3 commits into
Conversation
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
Member
|
You have unrelated commit here |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a stats contract violation in
DEMetropolisthat can break population sampling output handling and trigger CI failures like:ValueError: setting an array element with a sequenceRoot cause:
DEMetropolis.stats_dtypes_shapesdeclares scalar stats (tune: bool,scaling: float64),DEMetropolis.astepwas emitting:tuneasstr | Nonescalingas a NumPy arrayThis mismatch can propagate into downstream stats packing/trace handling and fail tests in
tests/sampling/test_population.py.Fix
In
DEMetropolis.astepstats payload:"tune": self.tune is not None(bool)"scaling": float(np.mean(self.scaling))(scalar float)This restores consistency with
stats_dtypes_shapesand aligns behavior withDEMetropolisZ(which already reports scalarscaling).Fixes #8169
Testing
Targeted population sampler checks:
Observed result relevant to this PR:
ValueError: setting an array element with a sequenceis no longer reproduced.test_checks_population_size: passtest_demcmc_warning_on_small_populations: pass