Add logccdf to LogNormal distribution#8166
Merged
Merged
Conversation
Documentation build overview
Show files changed (15 files in total): 📝 15 modified | ➕ 0 added | ➖ 0 deleted
|
ricardoV94
reviewed
Mar 4, 2026
ricardoV94
approved these changes
Mar 6, 2026
Member
|
Looks great @vybhav72954 |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v6 #8166 +/- ##
=====================================
Coverage ? 91.49%
=====================================
Files ? 124
Lines ? 19958
Branches ? 0
=====================================
Hits ? 18261
Misses ? 1697
Partials ? 0
🚀 New features to boost your workflow:
|
Contributor
Author
|
@ricardoV94 Can you please guide me if anyhting further is requried from my end to get this PR merged, thank you! |
7 tasks
Contributor
Author
|
Hi @ricardoV94 please let me know if anything further is required from my end in this PR, happy to make any adjustments in case i have missed anything |
ricardoV94
approved these changes
Mar 13, 2026
ricardoV94
force-pushed
the
feature/logccdf
branch
from
e34d68e to
b4f61fc
Compare
ricardoV94
force-pushed
the
feature/logccdf
branch
from
a210ec7 to
54bf883
Compare
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds an explicit
logccdf(log survival function) toLogNormalusingnormal_lccdf(mu, sigma, log(t))fromdist_math.py, consistent withNormal.logccdf.Unlike Weibull/Exponential, where the direct
logccdfis just thelogcdfintermediate minus thelog1mexpwrapper (which PyTensor's graph optimizer already rewrites), LogNormal'slogccdfcalls a genuinely different function (normal_lccdfvsnormal_lcdf), so an explicit registration is warranted.Also adds a
check_logccdftest helper topymc/testing.py, mirroringcheck_logcdf, to support testinglogccdfacross distributions.Changes
pymc/distributions/continuous.py: AddlogccdftoLogNormalpymc/testing.py: Addcheck_logccdfhelper andlogccdfimporttests/distributions/test_continuous.py: Addtest_lognormal_logccdfRelated Issue
Checklist
Type of change
NOTE - I have created the PR on the
v6branch assuming that's the right one, if this should point tobase, please let me know, and I will rebase accordingly!TIA, happpy to discuss if there are any concerns!