Log basic_RVs sampled in sample_*_predictive functions
#6142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricardoV94
force-pushed
the
log_resampled_varnames
branch
from
3e00114 to
1b83522
Compare
ricardoV94
changed the title
basic_RVs sampled in sample_*_predictive functions
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #6142 +/- ##
==========================================
+ Coverage 91.28% 92.58% +1.30%
==========================================
Files 101 101
Lines 20945 20948 +3
==========================================
+ Hits 19119 19395 +276
+ Misses 1826 1553 -273
|
ricardoV94
force-pushed
the
log_resampled_varnames
branch
from
1b83522 to
feb72ae
Compare
Member
Author
|
Only flaky test failing: #6091 |
lucianopaz
approved these changes
Sep 21, 2022
Member
lucianopaz
left a comment
lucianopaz
left a comment
There was a problem hiding this comment.
Looks great @ricardoV94 ! There was only a typo in a comment, and I’m not sure which word you wanted to put
ricardoV94
force-pushed
the
log_resampled_varnames
branch
from
feb72ae to
6479ad4
Compare
Member
Author
|
Merging, flaky test is documented in #6143 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5973
Major / Breaking Changes
Bugfixes / New features
Docs / Maintenance
basic_RVssampled in prior and posterior predictive