Fix quoted string handling #2835
Conversation
Commit 2dad7c0 introduced regression in the handling of strings with double quotes. The bug was even "featured" in the golden for test_quoted_entries.txt since `key 2` attribute was improperly parsed as literal string "key 2 = ". Signed-off-by: Benjamin Cabé <[email protected]>
|
Thanks a lot for the PR! |
@Anteru Oh wow, didn't expect this to be merged as it was still in draft (but thanks, I guess!) :) There's, I think, several other issues with the current implementation that I was hoping to address, in addition to adding the snippets allowing to add the missing test coverage ex: "key 4" would be to have coverage for what @ThomasWaldmann mentioned in #2834, which is still not quite right, by a fair margin :) 
|
|
But that's not really an |
ya, true -- given there's no common / agreed upon grammar for .ini files anyway, I think it's fair to say there will always be corner cases |
2 participants
Commit 2dad7c0 (PR #2767) introduced regression in the handling of strings with double quotes.
The bug was even "featured" in the golden for test_quoted_entries.txt since
key 2attribute was improperly parsed as literal string "key 2 = ".pygments/tests/snippets/ini/test_quoted_entries.txt
Lines 1 to 18 in 2dad7c0