Fix quoted string containing comment character #2767
Merged
+45
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The comment character ('#' or ';') included in a quoted value does not be interpreted as beginning of comment but as a character of the quoted value.
kartben
reviewed
Jan 5, 2025
| 'value1' Literal.String | ||
| '"' Literal.String | ||
| '\n ' Text.Whitespace | ||
| 'key 2 = ' Literal.String |
Contributor
There was a problem hiding this comment.
this is actually highlighting a bug in the current implementation, right?
Collaborator
There was a problem hiding this comment.
Yes. Thanks for spotting this. Tracked in #2835
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The comment character ('#' or ';') included in a quoted value does not be interpreted as beginning of comment but as a character of the quoted value.
This PR fixes #2720.