Fix regex for triple quoted strings in Turtle lexers #2758
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test cases for the turtle lexer did not include triple quoted strings (neither single nor double). The regex used to match the string contents matched every single character except escape characters, but crucially it also matched the triple quotes used to delineate the termination of such a string. The updated regex specifically excludes these characters.
Contributor
Author
|
@birkenfeld Any chance you could take a look at this? Thanks! |
Member
|
LGTM. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test cases for the turtle lexer did not include triple quoted strings (neither single nor double). The regex used to match the string contents matched every single character except escape characters, but crucially it also matched the triple quotes used to delineate the termination of such a string. The updated regex specifically excludes these characters.
Fixes #2744
Note: the same issue might also occur in the SPARQL lexer. However, I never really use SPARQL so I cannot verify if the same logic would apply.
This is my first contribution to Pygments, forgive me for any mistakes I made. I confirm I agree, am willing and am able to put my contributions under the BSD 2-clause license.
Before:
After:
