Native: fix error contrast ratio to meet WCAG AA guidelines #2600
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanas
reviewed
Dec 1, 2023
| @@ -1,3 +1,4 @@ | |||
| *.egg-info/ | |||
Contributor
There was a problem hiding this comment.
Could you explain why this is needed? We now use hatchling, which doesn't leave .egg-info directories around, unlike setuptools...
Contributor
Author
There was a problem hiding this comment.
Aha, I still have an old .egg-info dir from before the switch, and I expect others will too.
Collaborator
There was a problem hiding this comment.
I'll merge it as-is; I'm not too worried about more changes to the ignore list.
Anteru
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The red traceback and error text at https://peps.python.org/pep-0654/#handling-exception-groups, for example, "Traceback (most recent call last):" and "ValueError", has too low contrast:
Changing to Google Chrome's suggestion (see #2038 for how) improves it: