Try adding macOS CI #2594
Merged
Try adding macOS CI #2594
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@birkenfeld You were right: it was slower than the other runners. The run took ~1min 40s compared to ~40s for the others. This isn't a lot, but I'm not sure it's worth it either. For now I'll update this PR as @Anteru suggested (#2593 (comment)), i.e., only run macOS when a tag is pushed. |
Contributor
Author
|
Took me a while to figure out the trick, but this seems to be working now. In the "Checks" tab of this PR, one can see that Linux and Windows tests were run, as usual. On the other hand, after I created a tag for testing and pushed it to my fork, it triggered this run, with jobs for tests on macOS. They succeeded. |
Collaborator
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.