Skip to content

Replace pyflakes with Ruff #2592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Anteru merged 2 commits into from
Nov 20, 2023
Merged

Replace pyflakes with Ruff #2592

Anteru merged 2 commits into from
Nov 20, 2023

Conversation

@jeanas
Copy link
Contributor

@jeanas jeanas commented Nov 20, 2023

  • Fix/ignore Ruff lints
  • Replace pyflakes with Ruff in tox -e check

@birkenfeld
Copy link
Member

birkenfeld commented Nov 20, 2023

You're on a roll! Looks good.

@Anteru
Copy link
Collaborator

Anteru commented Nov 20, 2023

I was going to say, taking a week off or something :) Thanks, looks good. Makes me look really bad here though :(

@Anteru Anteru merged commit 982b37d into pygments:master Nov 20, 2023
@Anteru
Copy link
Collaborator

Anteru commented Nov 20, 2023

This is weird. When I run ruff check ., I get 1301 errors, unless I use ruff check --ignore E501 .. Why does tox not complain? It supposedly runs ruff check . unless I'm missing something?

@jeanas
Copy link
Contributor Author

jeanas commented Nov 20, 2023

Are you sure that you have the latest version of Ruff in your environment outside tox? Apparently, the default config disables some style lints for things that can be solved by running the formatter. Since that formatter is a recent addition, it's possible that the default changed.

@jeanas jeanas deleted the ruff branch November 20, 2023 21:27
@birkenfeld
Copy link
Member

birkenfeld commented Nov 21, 2023

I was going to say, taking a week off or something :) Thanks, looks good. Makes me look really bad here though :(

How does it make it you look bad? This is not a competition :)

@jeanas
Copy link
Contributor Author

jeanas commented Nov 21, 2023

How does it make it you look bad? This is not a competition :)

💯

@Anteru Anteru added this to the 2.18.0 milestone Apr 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.18.0

Development

Successfully merging this pull request may close these issues.

3 participants

@jeanas @birkenfeld @Anteru