-
Notifications
You must be signed in to change notification settings - Fork 766
Use hatchling as build backend #2573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reduces tox's setup time, as measured on an environment with no commands, from ~1.7s to ~0.8s. It also fixes requirements.txt and tox.ini not being included in sdists in spite of being part of the source tree.
|
Feels definitely snappier. Is hatchling commonly enough used so that this doesn't create problems for downstream packagers? |
|
Yes, hatchling is pretty popular these days. It's also used by some important projects like Jupyter, attrs and Black. |
|
Good to go then! |
|
Ok, I just tried this and |
Yes, this is the “build isolation” feature — by default,
Oh, that's right, good point. However, after looking into it, it seems that the consensus among packaging people is that normalizing the project name in sdist/wheel file names is better and setuptools should change to do it. See pypa/setuptools#3777 So let's just update the release procedure? |
|
This PR apparently broke the WASM build of Pygments with Pyodide in the CI, but I don't understand why. The error says |
|
Lower-case is totally fine for me, it's just something that needs to be mentioned in the changelog because there must be someone out there using a script which expects it upper-case. I don't know what's up with WASM. @birkenfeld ? |
|
I'm looking into the Pyodide problem now. |
|
(I've added a note to the CHANGES file about distribution file names.) |
|
#2580 should hopefully fix the CI. |
|
Indeed it does :) |
This reduces tox's setup time, as measured on an environment with no commands, from ~1.7s to ~0.8s.
It also fixes requirements.txt and tox.ini not being included in sdists in spite of being part of the source tree.