Skip to content

Conversation

@mo-anon
Copy link

@mo-anon mo-anon commented Oct 3, 2023

adding a new lexer for vyper (smart contract language): https://docs.vyperlang.org/en/stable/

A thing I require some help with: when running tox -e check the following error occurs:
pygments/lexers/vyper.py:4: wrong module name underline, should be ~~~...~

i am using tilde, so im not really sure whats the issue there.

thanks in advance.

@Anteru
Copy link
Collaborator

Anteru commented Oct 3, 2023

That problem is fairly easy: You have:

    pygments.lexers.vyper
    ~~~~~~~~~~~~~~~~~~

The length of the underline must match the text above, so you're missing a few more ~. I'll see if I can improve the script error for that.

@mo-anon
Copy link
Author

mo-anon commented Oct 3, 2023

That problem is fairly easy: You have:

    pygments.lexers.vyper
    ~~~~~~~~~~~~~~~~~~

The length of the underline must match the text above, so you're missing a few more ~. I'll see if I can improve the script error for that.

ty, fixed. tox -e check passes now.

@mo-anon mo-anon requested a review from Anteru October 4, 2023 16:40
@jeanas
Copy link
Contributor

jeanas commented Oct 10, 2023 via email

@mo-anon
Copy link
Author

mo-anon commented Oct 10, 2023

capturing groups for the whitespace and colon

i see. should be fixed now, my bad.

@mo-anon mo-anon requested a review from jeanas October 24, 2023 12:43
@jeanas
Copy link
Contributor

jeanas commented Nov 11, 2023

I've made a number of fixes that were more convenient for me to commit directly than to write on the diff. However, I unfortunately cannot push them, although you did tick the “allow edits by maintainers” box, because you created the PR from the master branch of your fork, which is protected. I'm going to close this PR and open another one with my fixes (next time, consider creating a feature branch for your PR).

@jeanas jeanas closed this Nov 11, 2023
jeanas added a commit that referenced this pull request Nov 13, 2023
@Anteru Anteru added this to the 2.17 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants