A couple small fixes in the OCaml lexer. #2521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"value" is not a keyword in OCaml. It was once a keyword in the so-called "revised" syntax of OCaml, but this syntax was never mainstream and is now essentially extinct.
"and" is a keyword in OCaml. It is used e.g. in "let x = 0 and y = 1". It is not an infix operator.
jeanas
reviewed
Sep 23, 2023
Contributor
|
Please fix the tests by updating the test output. You need to run |
Contributor
Author
|
Done, thanks. Indeed, I am using minted/pygments for my MPRI course! |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
anda keyword (so far, it was wrongly considered an infix operator) and removesvaluefrom the set of keywords (it is not a keyword).