Add support for YARA syntax #2453
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanas
reviewed
Jun 14, 2023
Co-authored-by: Jean Abou-Samra <[email protected]>
Co-authored-by: Jean Abou-Samra <[email protected]>
Co-authored-by: Jean Abou-Samra <[email protected]>
Co-authored-by: Jean Abou-Samra <[email protected]>
jeanas
reviewed
Jun 15, 2023
Contributor
jeanas
left a comment
jeanas
left a comment
There was a problem hiding this comment.
A few more comments, should be good to go afterwards.
Co-authored-by: Jean Abou-Samra <[email protected]>
Co-authored-by: Jean Abou-Samra <[email protected]>
Co-authored-by: Jean Abou-Samra <[email protected]>
Contributor
|
LGTM, but please have a look at the CI failures. Basically, you need to rerun |
Contributor
Author
|
Should be working now |
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is my first lexer I tried my hands on. Since we are dealing with a lot of YARA syntax in our technical documentation, I wanted to write a lexer for this. Please let me know if there is potential (most likely) to improve the regex.
Also had to remove the number and hex regex, since they caused some problems.
Thank you