Skip to content

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented May 28, 2023

Re: #2444 (comment)

Allow other jobs to continue, even if 3.12 falls.

@hugovk
Copy link
Contributor Author

hugovk commented May 29, 2023

Updated to temporarily skip warnings for 3.12 on the CI until pytest-dev/pytest#10894 is fixed.

@jeanas
Copy link
Contributor

jeanas commented May 29, 2023

Do we still need fail-fast: false then?

@hugovk
Copy link
Contributor Author

hugovk commented May 29, 2023

I still find it useful.

For example, I may open a PR that only fails for Python 3.7 because it uses a new API from 3.8.

Or it only fails on Windows due to path or encoding issues.

This change means we can clearly see it fail on a subset and pass for the rest, instead of failing for one and the others are all cancelled.

@jeanas jeanas merged commit 5ea3b0b into pygments:master May 29, 2023
@jeanas
Copy link
Contributor

jeanas commented May 29, 2023

Ok, fine.

@hugovk hugovk deleted the fail-fast-false branch May 29, 2023 09:31
@Anteru Anteru added this to the 2.16.0 milestone Aug 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants