Sort STYLE_MAP #2443
Merged
Sort STYLE_MAP #2443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sort STYLE_MAP in Alphabet order.
Contributor
People don't add styles often enough for this to be worth it. |
Contributor
Author
Yes I agree. It is not worth. Add more codes = add more chances to make bugs. |
This was referenced Aug 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I sorted STYLE_MAP in Alphabet order by using the following line of code.
sorted_style_map = dict(sorted(STYLE_MAP.items())).By the way, may I know that is there any particular reason to make the project team has to keep STYLE_MAP as a constant? I think it's a good idea to handle STYLE_MAP in the following flow.
Then when people add a new style, they can just write in whatever order they want. The script will sort it in alphabet order automatically.
Thanks xD