Native: adjust colours to meet WCAG AAA contrast guidelines #2038
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
First of all: Thanks for working on improved accessibility! However, I think something is up with your demo, both links show the exact same colors, and if I run the wave.webaim.org links , they show the same number of contrast errors? Am I missing something here? |
Contributor
Author
|
Ah sorry, I should have added this needs to be in dark mode. Either put your OS into dark mode or click the icon at the top right:
|
Contributor
Author
|
Some screenshots because my demo page will likely get reset to Before
After
|
Anteru
added
A-theming
Collaborator
|
Merged, thanks! The changes are subtle but worth it, IMHO, thanks for working on this. |
Contributor
Author
|
And thank you for maintaining Pygments, I find code in documentation much easier to read with syntax highlighting! |
Anteru
removed
the
changelog-update
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used both WAVE (Web Accessibility Evaluation Tool) and the CSS Overview panel in Chrome DevTools to identify these by checking https://python.github.io/peps/pep-0008/.
https://wave.webaim.org/report#/https://python.github.io/peps/pep-0008/
https://developer.chrome.com/blog/new-in-devtools-87/#css-overview
Some of the colours already met AA (all but one of these are for Native):
But I've bumped them all to AAA using Chrome's suggestions. They provide two suggestions, one to meet AA (4.5:1) and another for AAA (7:1).
For example, inspect element:
Click the colour box:
And click the icon to the right of the 🚫 to select AAA:
Demo
Before: https://python.github.io/peps/pep-0008/#other-recommendations
After: https://hugovk.github.io/peps/pep-0008/#other-recommendations
Before, 137 contrast errors: https://wave.webaim.org/report#/https://python.github.io/peps/pep-0008/
After, no contrast errors: https://wave.webaim.org/report#/https://hugovk.github.io/peps/pep-0008/