Whitespace token for Lexers [ijkl] #2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Merged. Sorry for leaving this open for so long, I meant to look at this earlier but couldn't make the time :( Thanks a lot again for this massive contribution! |
Contributor
Author
Thanks for reviewing it anyway! I should have split this into smaller chunks. It was just temping to reach the milestone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies lexers starting with the letters i, j, k, and l to use the Whitespace token - as much as efficiently doable.
Again, this regards #1905
This chunk got quite large... I should have included the javascript lexer to the html one.
Anyhow, when this PR is done, we should be half way through!
I don't expect any work on this soon. The latest release surely took a lot of time already =)