Whitespace token modernization - html/xml lexers - regarding #1905 #2012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeanas
reviewed
Mar 7, 2022
pygments/lexers/html.py
Outdated
| 'html-attribute-value'), | ||
| (r'[\w:-]+', Name.Attribute), | ||
| (r'\)', Text, '#pop'), | ||
| (r'\)', Whitespace, '#pop'), |
Contributor
There was a problem hiding this comment.
The parenthesis is not whitespace?
Contributor
Author
There was a problem hiding this comment.
You are right! This was by mistake
| @@ -0,0 +1,17 @@ | |||
| !!! XML | |||
Contributor
There was a problem hiding this comment.
Files in examplefiles/ usually end in the normal extension of the language, unlike snippets/.
Collaborator
|
Merged |
Contributor
|
There is still #2012 (comment) though. |
Collaborator
|
Thanks, just fixed both issues mentioned in the comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a more significant change to the xml lexer. I changed the tag detection to look more like the html ones, where a Tag token is used for the name, but punctuation tokens for characters like
[<>\\].I am not sure, whether the xml lexer was kept intentionally simple. That's why secluded this change into it's own commits here.