Modernize Whitespace token - regarding #1905 #1911
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks a lot! Yes, I wouldn't worry about getting everything perfect to be honest -- this is already a huge improvement and perfection will be likely never achieved anyways without some fully automated enforcement. |
Anteru
added
the
changelog-update
Anteru
removed
the
changelog-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modernizes the following lexers regarding usage of Whitespace Token for whitespace characters in the context of #1905.
including the respective example file outputs
The Business(cobol) lexer is only a partial sucess. There are some complex regex which i didn't want to unravel and would likely be beyond the scope of the related compaign (#1905). Since the demand might be really small for this lexer, this might be opened in a separate issue with help wanted?