Remove all unsafe from codebase, improve parsing speed#8
Conversation
ghost
commented
Nov 11, 2021
pyfisch
reviewed
Nov 13, 2021
Owner
pyfisch
left a comment
There was a problem hiding this comment.
Looks good! Can you address the comments, fix the formatting and silence clippy? Then its good to go!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, the
toint_1/2/4calls require both less unsafe as well as being faster, since they're specialized to the exact width they need to parse.I ran the benchmarks and got
Before:
After: